Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getter methods for ArgGroup. #4228

Closed
2 tasks done
aobatact opened this issue Sep 18, 2022 · 4 comments
Closed
2 tasks done

Getter methods for ArgGroup. #4228

aobatact opened this issue Sep 18, 2022 · 4 comments
Labels
A-builder Area: Builder API C-enhancement Category: Raise on the bar on expectations S-waiting-on-design Status: Waiting on user-facing design to be resolved before implementing

Comments

@aobatact
Copy link

Please complete the following tasks

Clap Version

3.2.22

Describe your use case

While I'm working with adding a Serialize impl at aobatact/clap-serde#46, I wanted to get the value from ArgGroup to serialize.

Describe the solution you'd like

Add a getter methods to ArgGroup like get_args and is_mutiple.

Alternatives, if applicable

No response

Additional Context

No response

@aobatact aobatact added the C-enhancement Category: Raise on the bar on expectations label Sep 18, 2022
@epage epage added A-builder Area: Builder API S-waiting-on-design Status: Waiting on user-facing design to be resolved before implementing labels Sep 28, 2022
@tony-go
Copy link
Contributor

tony-go commented Sep 29, 2022

Hi 👋

Is this a valid entry point for this issue? https://github.com/clap-rs/clap/blob/master/src/builder/arg_group.rs

@epage
Copy link
Member

epage commented Sep 29, 2022

That is the file that would need to be updated for this issue, yes

@tony-go
Copy link
Contributor

tony-go commented Sep 29, 2022

Hey @aobatact 👋

I'm trying to make my first Rust contribution. And as we used Clap in the RIA book, I was looking forward to resolving an issue here ^^

Maybe you plan to tackle this issue yourself? Otherwise, I'll happy to help. :)

epage added a commit to epage/clap that referenced this issue Sep 29, 2022
This is a part of clap-rs#4228

I thought I needed this for another change but it turned out I didn't.
@aobatact
Copy link
Author

aobatact commented Oct 1, 2022

Hi @tony-go !

I don't have time to be involved in this right now and would be happy if you could help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-builder Area: Builder API C-enhancement Category: Raise on the bar on expectations S-waiting-on-design Status: Waiting on user-facing design to be resolved before implementing
Projects
None yet
Development

No branches or pull requests

3 participants