Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose is_multiple & get_args API for ArgGroup #4336

Merged
merged 6 commits into from
Oct 3, 2022

Conversation

tony-go
Copy link
Contributor

@tony-go tony-go commented Oct 3, 2022

☝🏼 I open it as a draft to see if my approach to doc and test is good.

Context

Ref: #4228

Improvements

  • add is_multiple API
  • add get_args API

@tony-go tony-go changed the title feat(ArgGroup): expose is_multiple API feat: expose is_multiple API for ArgGroup Oct 3, 2022
@tony-go tony-go force-pushed the 4228-getter-arggroup branch from 2b10342 to 47925fd Compare October 3, 2022 05:40
@tony-go tony-go force-pushed the 4228-getter-arggroup branch from 47925fd to e43620b Compare October 3, 2022 05:45
@tony-go tony-go changed the title feat: expose is_multiple API for ArgGroup feat: expose is_multiple & get_args API for ArgGroup Oct 3, 2022
@tony-go tony-go marked this pull request as ready for review October 3, 2022 06:57
src/builder/arg_group.rs Outdated Show resolved Hide resolved
src/builder/arg_group.rs Outdated Show resolved Hide resolved
src/builder/arg_group.rs Outdated Show resolved Hide resolved
@tony-go tony-go force-pushed the 4228-getter-arggroup branch from d192d98 to 88f0c5f Compare October 3, 2022 19:24
@tony-go tony-go requested a review from epage October 3, 2022 20:03
@epage epage merged commit 7f98947 into clap-rs:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants