fix: ArgRequiredElseHep is viable alt to SubcommandRequiredElseHelp #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we can use `SubcommandRequired | ArgRequiredElseHelp`, this setting offers little value but requires we track required subcommands with two different settings. Deprecating as the cost is not worth the benefit anymore. Issue clap-rs#3280 will see the derive updated
|
I decided to hold off on updating the derive (see #3455). I'm torn on whether it qualifies for a compatibility note or would be considered a breaking change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3280 will see us switch the derive to
ArgRequiredElseHep. This prepares the way by resolving some lingering issues with it. Now, there is little value in offeringSubcommandRequiredElseHelp, so we also deprecate it.