Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ArgRequiredElseHep is viable alt to SubcommandRequiredElseHelp #3456

Merged
merged 6 commits into from
Feb 11, 2022
Merged

fix: ArgRequiredElseHep is viable alt to SubcommandRequiredElseHelp #3456

merged 6 commits into from
Feb 11, 2022

Commits on Feb 11, 2022

  1. perf(validate): Remove unnecesarry walking of args

    @epage
    epage committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    9824f8d View commit details
    Browse the repository at this point in the history

  2. refactor(validate): Drop us to one req check

    @epage
    epage committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    8e5ce6c View commit details
    Browse the repository at this point in the history

  3. refactor(validate): Clarify subcmd check intent

    @epage
    epage committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    c0fd675 View commit details
    Browse the repository at this point in the history

  4. fix(validate): Give precedence to ArgRequiredElseHelp

    @epage
    epage committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    e8e4691 View commit details
    Browse the repository at this point in the history

  5. docs: Stop demonstrating SubcommandRequiredElseHelp

    @epage
    epage committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    8f201d8 View commit details
    Browse the repository at this point in the history

  6. fix: Deprecate SubcommandRequiredElseHelp 

    Now that we can use `SubcommandRequired |
ArgRequiredElseHelp`, this setting offers little value but requires we
track required subcommands with two different settings.  Deprecating as
the cost is not worth the benefit anymore.

Issue clap-rs#3280 will see the derive updated
    @epage
    epage committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    4895a32 View commit details
    Browse the repository at this point in the history