Detectors for Prometheus varnish exporter #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsicart
requested review from
BzSpi,
cvauvarin,
JMHAUTBOIS-Claranet,
pdecat,
Shr3ps and
tchernomax
as code owners
JMHAUTBOIS-Claranet
requested changes
Jun 20, 2023
rsicart
force-pushed
the
rsi/prometheus-varnish-exporter
branch
from
36af2d5
to
58978d1
Compare
|
@JMHAUTBOIS-Claranet @haedri do you believe that this PR will be good for milestone v1.25.0? |
JMHAUTBOIS-Claranet
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same detectors configured for smartagent varnish module, but with a prometheus exporter source.