-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and improve Riemann solver code #176
Open
ketch
wants to merge
11
commits into
clawpack:master
Choose a base branch
from
ketch:implicit_none
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Nov 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b6a8635 - Browse repository at this point
Copy the full SHA b6a8635View commit details
Commits on Sep 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 44b8200 - Browse repository at this point
Copy the full SHA 44b8200View commit details
Commits on Sep 15, 2024
-
Add a temporary testing workflow
It uses PyClaw's tests since, to my understanding, an ensemble of local regression tests for the Riemann repository using Pytest would require the appropriate argument intents of the rp* subroutines to be explicitly declared already. So the Riemann solvers should be modernized first. Also, the test for shallow water on the sphere is omitted for the moment.
Configuration menu - View commit details
-
Copy full SHA for 3e0cd42 - Browse repository at this point
Copy the full SHA 3e0cd42View commit details -
Configuration menu - View commit details
-
Copy full SHA for c609aea - Browse repository at this point
Copy the full SHA c609aeaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 92f03d1 - Browse repository at this point
Copy the full SHA 92f03d1View commit details
Commits on Sep 16, 2024
-
implicit none in SWEs on the sphere
The PyClaw test that uses this RS is skipped in the testing workflow since it leads to a core dump (I suspect this has to do with the OS or the system architecture). However, this test passes locally for me (before and after the implicit none changes).
Configuration menu - View commit details
-
Copy full SHA for 03c3d0f - Browse repository at this point
Copy the full SHA 03c3d0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ec05726 - Browse repository at this point
Copy the full SHA ec05726View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60a9ff9 - Browse repository at this point
Copy the full SHA 60a9ff9View commit details
Commits on Sep 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f84a68c - Browse repository at this point
Copy the full SHA f84a68cView commit details -
Temporary fix Pytest not collecting AMRClaw tests
The regression tests in AMRClaw are not being collected by Pytest. They just have to be renamed. This is a temporary fix to run them from this repo in a single pytest session.
Configuration menu - View commit details
-
Copy full SHA for fcb7699 - Browse repository at this point
Copy the full SHA fcb7699View commit details
Commits on Sep 19, 2024
-
Merge pull request #4 from carlosmunozmoncayo/implicit_none
Update branch, add testing workflow, use implicit none in more Riemann solvers
Configuration menu - View commit details
-
Copy full SHA for 2786fc4 - Browse repository at this point
Copy the full SHA 2786fc4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.