Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and improve Riemann solver code #176

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Commits on Nov 3, 2023

  1. Configuration menu
    Copy the full SHA
    b6a8635 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Configuration menu
    Copy the full SHA
    44b8200 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. Add a temporary testing workflow

    It uses PyClaw's tests since, to my understanding, an ensemble
    of local regression tests for the Riemann repository using
    Pytest would require the appropriate argument intents of the
    rp* subroutines to be explicitly declared already.
    So the Riemann solvers should be modernized first.
    
    Also, the test for shallow water on the sphere is omitted for the moment.
    carlosmunozmoncayo committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    3e0cd42 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c609aea View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    92f03d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. implicit none in SWEs on the sphere

    The PyClaw test that uses this RS is skipped in the testing
    workflow since it leads to a core dump
    (I suspect this has to do with the OS or the system
    architecture).
    
    However, this test passes locally for me (before and after the
    implicit none changes).
    carlosmunozmoncayo committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    03c3d0f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec05726 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    60a9ff9 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Configuration menu
    Copy the full SHA
    f84a68c View commit details
    Browse the repository at this point in the history
  2. Temporary fix Pytest not collecting AMRClaw tests

    The regression tests in AMRClaw are not being collected by Pytest. They
    just have to be renamed. This is a temporary fix to run them from this
    repo in a single pytest session.
    carlosmunozmoncayo committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    fcb7699 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Merge pull request #4 from carlosmunozmoncayo/implicit_none

    Update branch, add testing workflow, use implicit none in more Riemann solvers
    ketch authored Sep 19, 2024
    Configuration menu
    Copy the full SHA
    2786fc4 View commit details
    Browse the repository at this point in the history