Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import the command you actually use #175

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Conversation

felkerch
Copy link
Contributor

Description of Changes

Claycli loads requirements for all of its commands even though only one is ever run. compile in particular takes a while to start up, so this PR parses the command line args and calls require only on that arg.

New:

$ time clay config -k local -r json
{"level":30,"time":1592346996492,"msg":"MadeUpAccessKey","pid":9274,"hostname":"Chase-Felker-MacBook-Pro.local","name":"claycli","claycliVersion":"3.12.1","command":"config","type":"info","_label":"INFO","v":1}

real	0m0.234s
user	0m0.176s
sys	0m0.058s

Old:

$ time clay config --key stage  --reporter json
{"level":30,"time":1592252061518,"msg":"your-key","pid":78980,"hostname":"Chase-Felker-MacBook-Pro.local","name":"claycli","claycliVersion":"3.12.1","command":"config","type":"info","_label":"INFO","v":1}
real	0m1.716s
user	0m1.560s
sys	0m0.420s

@coveralls
Copy link

coveralls commented Jun 16, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling e66615a on slategroup:faster-claycli into 14190ec on clay:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a1dd9b2 on slategroup:faster-claycli into 14190ec on clay:master.

Copy link
Member

@jjpaulino jjpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄‍♂️

@felkerch
Copy link
Contributor Author

Anything else I can do to get this ready for release?

@elgreg
Copy link

elgreg commented Sep 4, 2020

We've been using this locally and it's faster. Anything we can do to get it merged?

@jpope19 jpope19 merged commit 9c202bb into clay:master Sep 18, 2020
phyllisstein added a commit that referenced this pull request Jan 20, 2021
* master:
  3.13.0
  Allow multiple leading underscores in field names (#179)
  Introduces release workflow via CircleCI (#180)
  3.12.2
  import the command you actually use (#175)
  3.12.1
  bugfix: enables CSS minification via environment variable (#172)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants