Introduces release workflow via CircleCI #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new release workflow that ensures NPM packages are published in a consistent manner. The typical workflow will involve creating a release from the **base** branch (currently: `master`). 1. Start by creating a prerelease candidate, selecting the correct version to increment. ```sh npm run release (prepatch|preminor|premajor) ``` 2. This will run `npm version (selection)` and push the branch/tag. 3. CircleCI will publish a package with `--tag=prerelease`, eg. `v8.17.1-0`. 4. When we are ready to promote a release from `prerelease` to `latest` run the following. ```sh npm run release (patch|minor|major) ``` 5. This will run `npm version (selection)` and push the branch/tag. 6. CircleCI will publish a package, eg `v8.17.1`.
mattoberle
force-pushed
the
circleci/releases
branch
from
d6e9f90
to
1727b3c
Compare
The `node-sass` package v4.11.0 only supported LTS releases <= 10. The new version should support <= 14.
We were failing tests for things like extra parentheses that were added for visual clarification. This commit removes the failure for eslint warnings (otherwise what is the point of a warning?).
jpope19
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new release workflow that ensures NPM packages are published in a consistent manner.
The typical workflow will involve creating a release from the base branch (currently:
master).This will run
npm version (selection)and push the branch/tag.CircleCI will publish a package with
--tag=prerelease, eg.v8.17.1-0.When we are ready to promote a release from
prereleasetolatestrun the following.This will run
npm version (selection)and push the branch/tag.CircleCI will publish a package, eg
v8.17.1.This pull request upgrades
node-sassfrom v4.11.0 to v4.14.0.The previous version only supported builds on node versions < 10.