-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-css 2.0.4 IE8 issue #197
Comments
@XhmikosR currently we assume that the only way to keep repeated properties as they are is by grouping them one after another. This actually should be fixed in 2.1 with the new override logic. It is all due to this selector: .show-grid [class^=col-] {
padding-top:10px;
padding-bottom:10px;
background-color:#eee;
border:1px solid #ddd;
background-color:rgba(86,61,124,.15);
border:1px solid rgba(86,61,124,.2)
} |
OK, thanks for looking into this. For the time being I have turned advanced optimizations off in case that PR is merged before the next clean-css version. |
Let's see if new merging will help here. |
@GoalSmashers: this seems fixed too after 2.1.8. Can you confirm? |
Finally have hands on IE8 - let me check. |
@XhmikosR Are you sure it is fixed? My tests show otherwise. |
I just re-ran minify.bat from my test case, after having 2.0.8 installed... Then opened IE, set up compatibility mode to 8. Everything works the same with and without advanced optimizations. |
I'll check again! |
...unless it's because of the properties order. IIRC I made a couple of relevant changes a while ago. I'll check again when I'm back home. |
* Adds border processor so all border declarations are reprocessed into: <width> <style> <color>.
Folder with all the relevant files: https://dl.dropboxusercontent.com/u/3607425/clean-css_2.0.4_ie8_bug.zip
The text was updated successfully, but these errors were encountered: