Enable clean-css's advanced optimizations. #13465
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the filesize reduction? And how's this look locally for you? No problems since that issue you linked to, or are you saying there still might be problems? |
|
Personally, I can't reproduce the issue anymore locally, that's why I made this PR :P Size difference; negligible. But advanced optimizations are on by default. |
|
I don't see much of a difference at all, and it's only in the docs CSS, I'm going to punt on this one. |
|
This wasn't basically a question. I was gonna merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested IE 8-10, and normal browsers; everything seems to be fine now.
The problem we had was with grid not showing right, see clean-css/clean-css#197.
If someone else can confirm this is ok, I guess it makes sense to not disable advanced optimizations anymore.