Add dependency on python3-apt
#273
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
civerachb-cpr
requested review from
roni-kreinin and
luis-camero
and removed request for
a team
🧪 CI InsightsHere's what we observed from your CI run for 7841e56. 🟢 All jobs passed!But CI Insights is watching 👀 |
nnarain-cpr
reviewed
Oct 7, 2025
| <exec_depend version_gte="2.5.0">clearpath_diagnostics</exec_depend> | ||
| <exec_depend version_gte="2.5.0">clearpath_manipulators</exec_depend> | ||
|
|
||
| <exec_depend>python3-apt</exec_depend> |
There was a problem hiding this comment.
does the generator rely on doing apt things?
There was a problem hiding this comment.
Yes:
- Import happens here: https://github.com/clearpathrobotics/clearpath_common/blob/jazzy/clearpath_generator_common/clearpath_generator_common/param/platform.py#L34
- The apt cache is used to check the MCU firmware version here: https://github.com/clearpathrobotics/clearpath_common/blob/jazzy/clearpath_generator_common/clearpath_generator_common/param/platform.py#L487-L498
This feature was added somewhat recently, but our standard Ubuntu image includes that package by default, so we never ran into a situation where the dependency was missing before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mike pointed out that in his docker container he had issues running the generator because the Python
aptpackage wasn't available.Adding the package to the exec depends should fix this.