Skip to content

Add dependency on python3-apt #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: rc/jazzy/2.8
Choose a base branch
from
Open

Add dependency on python3-apt #273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions clearpath_generator_common/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@
<exec_depend version_gte="2.5.0">clearpath_diagnostics</exec_depend>
<exec_depend version_gte="2.5.0">clearpath_manipulators</exec_depend>

<exec_depend>python3-apt</exec_depend>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the generator rely on doing apt things?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes:

  1. Import happens here: https://github.com/clearpathrobotics/clearpath_common/blob/jazzy/clearpath_generator_common/clearpath_generator_common/param/platform.py#L34
  2. The apt cache is used to check the MCU firmware version here: https://github.com/clearpathrobotics/clearpath_common/blob/jazzy/clearpath_generator_common/clearpath_generator_common/param/platform.py#L487-L498

This feature was added somewhat recently, but our standard Ubuntu image includes that package by default, so we never ran into a situation where the dependency was missing before.


<test_depend>ament_lint_auto</test_depend>
<test_depend>ament_lint_common</test_depend>
<test_depend>ament_cmake_pytest</test_depend>
Expand Down
Loading