Skip to content

Conversation

efernandez
Copy link
Member

This introduces the following changes:

  1. Always read wheel joint position and velocity, simplifying the previous logic.
  2. If wheel position/velocity is used to either compute the pose or twist, check for NaNs (this moves the previous check for NaNs).
  3. Add the pose_from_joint_position (default: True) and twist_from_joint_position (default: False) params, which replace the position_feedback one.
  4. Rename v_ variables into dp_ when their meaning is "difference of position" (or incremental position) and not velocity.

@efernandez efernandez force-pushed the pose_twist_from_position_velocity branch from c05320c to 04d0cc3 Compare January 28, 2016 23:49
@efernandez
Copy link
Member Author

Now that @p6chen 's #17 is merged, do you have any comments on this PR?

@servos @paulbovbel @afakihcpr

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking of moving this (the reading) to the very top of the update method, so the values are readed the closest possible to the time the control cycle starts.

Now there's no problem reading before setting the dynamic params.

@paulbovbel
Copy link

Nice, LGTM

@afakihcpr
Copy link

LGTM

@efernandez efernandez force-pushed the pose_twist_from_position_velocity branch from 04d0cc3 to 22b106a Compare February 1, 2016 15:15
@efernandez
Copy link
Member Author

Thanks.

Note that I've just push a fix to the velocity feedback test, which now uses the param pose_from_joint_position instead of the old position_feedback one.

Merging...

efernandez pushed a commit that referenced this pull request Feb 1, 2016
…n_velocity

Allow computing pose/twist from position/velocity
@efernandez efernandez merged commit 8f3eec0 into indigo-devel Feb 1, 2016
@efernandez efernandez deleted the pose_twist_from_position_velocity branch February 1, 2016 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants