fix(localizations): Outdated structure in es-CR #6181
Conversation
🦋 Changeset detectedLatest commit: 00c10f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 WalkthroughWalkthroughThis update introduces a patch for the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/localizations/src/es-CR.ts (1)
582-583: Add missing accent in subtitleWaitlist
Spanish requires "cuándo" with an accent.Apply this diff:
- 'Los registros están desactivados actualmente. Para ser el primero en saber cuando estemos listos, únete a la lista de espera', + 'Los registros están desactivados actualmente. Para ser el primero en saber cuándo estemos listos, únete a la lista de espera',
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.changeset/red-sites-crash.md(1 hunks)packages/localizations/src/es-CR.ts(10 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Formatting | Dedupe | Changeset
- GitHub Check: Build Packages
- GitHub Check: semgrep/ci
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (7)
packages/localizations/src/es-CR.ts (6)
17-21: Approve addition of new commerce keys
The new keys (addPaymentMethod,alwaysFree,annually,availableFeatures) align with the default resource and follow existing naming conventions.
347-349: Multiline passkey subtitle formatted for readability
Reformatting to a multiline string is consistent and improves maintainability.
430-430: Approve added resendButton in Sign-In emailLink
The new prompt matches other locales and UX patterns.
448-448: Approve added resendButton in Forgot Password
Provides a clear retry option consistent with other flows.
537-538: Approve updated subtitle in Sign-Up emailLink
The new instruction string is clear and mirrors default locale content.
702-710: Rename billingPage section and update its keys
The__experimental_billingPagesection has been correctly renamed tobillingPage, header titles updated, andpaymentSourcesSectionadded. This mirrors the default resource structure..changeset/red-sites-crash.md (1)
1-6: Approve changeset for es-CR patch
The changeset correctly declares apatchfor@clerk/localizationsand summarizes the fix.
| title__statementId: 'Número de factura', | ||
| title__subscriptionBegins: 'La suscripción empieza', | ||
| title__totalPaid: 'Total pagado', |
There was a problem hiding this comment.
Translation mismatch: title__statementId still reads "Número de factura"
The key has been renamed to title__statementId but the string still refers to an invoice. It should reflect "statement".
Apply this diff:
- title__statementId: 'Número de factura',
+ title__statementId: 'Número de estado de cuenta',📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| title__statementId: 'Número de factura', | |
| title__subscriptionBegins: 'La suscripción empieza', | |
| title__totalPaid: 'Total pagado', | |
| title__statementId: 'Número de estado de cuenta', | |
| title__subscriptionBegins: 'La suscripción empieza', | |
| title__totalPaid: 'Total pagado', |
🤖 Prompt for AI Agents
In packages/localizations/src/es-CR.ts around lines 39 to 41, the translation
for the key title__statementId incorrectly reads "Número de factura" which means
"invoice number." Update the string to correctly reflect "statement" instead of
"invoice" to match the renamed key, ensuring the translation aligns with the
intended meaning.
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/elements
@clerk/clerk-expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/remix
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
commit: |
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
Bug Fixes
New Features
Style
Documentation