Minor attribute cleanups for C# module #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A follow-up to #1719: - Hide `ColumnAttrs` and base `ColumnAttribute` classes into `SpacetimeDB.Internal` since they shouldn't be accessed by user. - Remove legacy `PrimaryKeyIdentity` alias as `ColumnAttrs` is no longer part of the public API. - Extend `ParseAs` helper to support abstract classes by accepting an explicit type. - Reuse `ParseAs` in couple of places instead of manual parsing. - Combine attributes by table early during parsing to reduce number of stored elements that need to be cached and iterated over. - Stringify ColumnAttrs as variant name again.
lcodes
reviewed
Sep 27, 2024
|
|
||
| [Flags] | ||
| public enum ColumnAttrs : byte | ||
| namespace SpacetimeDB | ||
| { |
There was a problem hiding this comment.
Don't think the toplevel ns needs {}; namespace Internal {} is fine to use with namespace SpacetimeDB; afaik
There was a problem hiding this comment.
It's necessary here because you can't mix file-scoped and regular namespace syntax, C# will complain. Idk why they made it so, but 🤷♂️
lcodes
approved these changes
Sep 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
A follow-up to #1719:
ColumnAttrsand baseColumnAttributeclasses intoSpacetimeDB.Internalsince they shouldn't be accessed by user.PrimaryKeyIdentityalias asColumnAttrsis no longer part of the public API.ParseAshelper to support abstract classes by accepting an explicit type.ParseAsin couple of places instead of manual parsing.API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!