Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jeremie/cs module #1719

Merged
merged 27 commits into from
Sep 27, 2024
Merged

Jeremie/cs module #1719

merged 27 commits into from
Sep 27, 2024

Conversation

lcodes
Copy link
Contributor

@lcodes lcodes commented Sep 18, 2024

Updates runtime and codegen to support multiple tables per row type

@lcodes lcodes added the abi-break A PR that makes an ABI breaking change label Sep 18, 2024
@lcodes lcodes requested a review from RReverser September 18, 2024 04:21
@RReverser
Copy link
Member

Just to duplicate a note from DMs - I noticed a few things in the PR that would be caught by the codegen tests, and looks like the snapshots haven't been updated in the PR. Can you please run ...\bindings-csharp> dotnet test and fixup the issues it finds and commit the updated snapshots? Otherwise I'm afraid I might be catching things in review that those tests would already catch as well.

Also #1718 might help with some attribute parsing here.

@lcodes lcodes mentioned this pull request Sep 19, 2024
Closed
@lcodes lcodes added this pull request to the merge queue Sep 27, 2024
Merged via the queue into master with commit 3234906 Sep 27, 2024
8 checks passed
RReverser added a commit that referenced this pull request Sep 27, 2024
@RReverser
Minor attribute cleanups for C# module
556f268 
A follow-up to #1719:

 - Hide `ColumnAttrs` and base `ColumnAttribute` classes into `SpacetimeDB.Internal` since they shouldn't be accessed by user.
 - Remove legacy `PrimaryKeyIdentity` alias as `ColumnAttrs` is no longer part of the public API.
 - Extend `ParseAs` helper to support abstract classes by accepting an explicit type.
 - Reuse `ParseAs` in couple of places instead of manual parsing.
 - Combine attributes by table early during parsing to reduce number of stored elements that need to be cached and iterated over.
 - Stringify ColumnAttrs as variant name again.
This was referenced Sep 27, 2024
Merged
Merged
RReverser added a commit that referenced this pull request Sep 28, 2024
@RReverser
Migrate bench-cs to the new API
b51926c 
I think it got missed in #1719. Migrated myself to the new API and added it to the solution.
RReverser added a commit that referenced this pull request Sep 28, 2024
@RReverser
Migrate bench-cs to the new API
dc3cd55 
I think it got missed in #1719. Migrated myself to the new API and added it to the solution.
@RReverser RReverser mentioned this pull request Sep 28, 2024
Merged
2 tasks
RReverser added a commit that referenced this pull request Sep 28, 2024
@RReverser
Migrate bench-cs to the new API
3c89469 
I think it got missed in #1719. Migrated myself to the new API and added it to the solution.
Centril pushed a commit that referenced this pull request Sep 29, 2024
@lcodes @Centril
Jeremie/cs module (#1719)
d352e45
RReverser added a commit that referenced this pull request Sep 30, 2024
@RReverser
Migrate bench-cs to the new API
ad19f21 
I think it got missed in #1719. Migrated myself to the new API and added it to the solution.
RReverser added a commit that referenced this pull request Sep 30, 2024
@RReverser
Migrate bench-cs to the new API
a12c69c 
I think it got missed in #1719. Migrated myself to the new API and added it to the solution.
RReverser added a commit that referenced this pull request Sep 30, 2024
@RReverser
Migrate bench-cs to the new API
e3156a1 
I think it got missed in #1719. Migrated myself to the new API and added it to the solution.
RReverser added a commit that referenced this pull request Sep 30, 2024
@RReverser
Migrate bench-cs to the new API
a060fdd 
I think it got missed in #1719. Migrated myself to the new API and added it to the solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RReverser RReverser RReverser approved these changes

Assignees
No one assigned
Labels
abi-break A PR that makes an ABI breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcodes @RReverser