[C#] Migrate bench-cs to the new API #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RReverser
force-pushed
the
ingvar/update-bench-cs
branch
from
278875a to
b3d8309
Compare
lcodes
approved these changes
Sep 29, 2024
RReverser
force-pushed
the
ingvar/update-bench-cs
branch
from
b3d8309 to
7241927
Compare
RReverser
force-pushed
the
ingvar/codegen-test-for-multi-tables
branch
from
fd85cd6 to
de5fa2a
Compare
RReverser
changed the base branch from
ingvar/codegen-test-for-multi-tables
to
master
RReverser
force-pushed
the
ingvar/update-bench-cs
branch
from
7241927 to
6b03913
Compare
RReverser
force-pushed
the
ingvar/update-bench-cs
branch
from
6b03913 to
240e6d8
Compare
I think it got missed in #1719. Migrated myself to the new API and added it to the solution.
RReverser
force-pushed
the
ingvar/update-bench-cs
branch
from
240e6d8 to
34306b8
Compare
This makes it behave closer to spacetime build.
Now that we don't build test projects by default, other deps are getting installed after we already generated nuget.config, and fail to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
I think it got missed in #1719. Migrated myself to the new API and added it to the solution.
API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!