Add a check in apropos var-query-map #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cartmanishere
force-pushed
the
apropos-query
branch
from
902231a
to
6c90676
Compare
|
The change looks good to me. We should also mention it in the changelog. |
Cartmanishere
force-pushed
the
apropos-query
branch
2 times, most recently
from
a9e0340
to
f8f1c9f
Compare
|
Added the pull request in the changelog. |
SevereOverfl0w
approved these changes
Feb 20, 2020
bbatsov
reviewed
Feb 20, 2020
CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ | |||
| * [#663](https://github.com/clojure-emacs/cider-nrepl/pull/663): Fix non-recognized `recur` inside `case` in the debugger. | |||
| * [#664](https://github.com/clojure-emacs/cider-nrepl/pull/664): Fix continue-all in conditional break. | |||
| * [#665](https://github.com/clojure-emacs/cider-nrepl/pull/665): Fix form location in map literals. | |||
| * [#666](https://github.com/clojure-emacs/cider-nrepl/pull/666): Add a check in apropos var-query-map. | |||
There was a problem hiding this comment.
This should be under master. Add a new "Bugs fixed" section there, as 0.24 was release a few days ago.
Cartmanishere
force-pushed
the
apropos-query
branch
from
f8f1c9f
to
d29c89e
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change as described in #530.
In
aproposmiddleware, if noqueryis passed in the message then a redundant regex is formed.This is because there is no condition that checks whether the value exists before constructing the regex.
I have added such a check. I have also added a test for this specific case.