Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline navigating from *cider-error* to the inspector #3565

Closed
vemv opened this issue Nov 1, 2023 · 3 comments · Fixed by #3570
Closed

Streamline navigating from *cider-error* to the inspector #3565

vemv opened this issue Nov 1, 2023 · 3 comments · Fixed by #3570

Comments

@vemv
Copy link
Member

vemv commented Nov 1, 2023

Context

*cider-error* shows ex-data when displaying a given exception. Said ex-data can be intrincate, and therefore jumping to the Inspector is a natural thing to want.

Currently, if I press RET, nothing will happen (other than newline: Buffer is read-only: #<buffer *cider-error*>)

Proposal

When hitting RET, the given exception should be inspected.

Notes

*cider-error* can have N causes. RET ing each cause should inspect a different object.

It probably would be idea to store in a var (e.g. cider.nrepl.middleware.ex/xxx) the current exception being shown in *cider-error*, given that it doesn't necessarily corresponds to *e.

@rrudakov
Copy link
Contributor

rrudakov commented Nov 1, 2023

Maybe instead of RET it could be p (the same way it's done in debugger)? Hitting RET on a stacktrace item jumps to the location, I guess it might be confusing.

@vemv
Copy link
Member Author

vemv commented Nov 1, 2023

Both considerations sound right to me 👍 - thanks

vemv added a commit to clojure-emacs/cider-nrepl that referenced this issue Nov 2, 2023
vemv added a commit to clojure-emacs/cider-nrepl that referenced this issue Nov 2, 2023
vemv added a commit to clojure-emacs/cider-nrepl that referenced this issue Nov 2, 2023
vemv added a commit to clojure-emacs/cider-nrepl that referenced this issue Nov 3, 2023
vemv added a commit to clojure-emacs/cider-nrepl that referenced this issue Nov 3, 2023
vemv added a commit to clojure-emacs/cider-nrepl that referenced this issue Nov 3, 2023
@vemv
Copy link
Member Author

vemv commented Nov 3, 2023

Besides from p I'm making this simply clickable - good gateway drug to bring more users to the Inspector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants