Inspector - misc #3570
Inspector - misc #3570
Conversation
| cider-inspector-max-atom-length | ||
| cider-inspector-max-coll-size | ||
| 'v2))) | ||
| (when (nrepl-dict-get result "value") |
There was a problem hiding this comment.
I had to do this v2 refactoring which keeps backward compat.
All of the inspector usage here was coupled to the "value" attr, which was hindering access to other attrs (the "doc-fragments" attr in particular, which needs separate tratment given that it's processed through cider--render-docstring)
| |=== | ||
| | Action | Description | ||
|
|
||
| | kbd:[click] or kbd:[p] |
There was a problem hiding this comment.
cider-debug has bound:
["Inspect current value" (cider-debug-mode-send-reply ":inspect") :keys "p"]
, so it would seem consistent.
However we could use both p and i - seems harmless given that this keymap is constrained to a single given string.
There was a problem hiding this comment.
Yeah, that'd be good. I'm guessing the debugger couldn't use i as it was already taken by inject. Lots of functionality got weird keybindings if it was added later in the lifecycle of the project and the natural keybindings were already taken by something else.
vemv
force-pushed
the
inspector-nov-refinements
branch
from
b0e4199 to
ccf0b1c
Compare
| (insert (format "%d. " num) | ||
| (propertize note 'font-lock-face 'font-lock-comment-face) " " | ||
| (propertize class 'font-lock-face class-face) | ||
| (propertize class 'font-lock-face class-face 'mouse-face 'highlight) |
There was a problem hiding this comment.
@bbatsov - added 'mouse-face 'highlight following Slack feedback
|
I tried the refactored defuns one by one and they keep working as usual - merging |
cider-find-keyworddocstring*cider-error*: open a given exception in the Inspector by clicking it*cider-error*to the inspector #3565Cheers - V