Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid overlays and messages on stderr that is unrelated to exception handling #3608

Closed
wants to merge 1 commit into from

Conversation

vemv
Copy link
Member

@vemv vemv commented Jan 21, 2024

Fixes #3587

@vemv
Copy link
Member Author

vemv commented Jan 21, 2024

@rrudakov kindly LMK if this would fix it

(from my experiments/analysis it would, but I never got to reproduce the Timbre error)

It would solve the overlays and messages alike, since the message is produced by the overlay function

Cheers - V

@vemv
Copy link
Member Author

vemv commented Jan 21, 2024

Mmm, I'll have to refine this approach, because it essentially relies on analyze-last-stacktrace.

There's no guarantee that the 'last stacktrace' is related to the 'most recent eval' - it could store an unrelated exception from prior evals.

This could be quite easily fixed by changing analyze-last-stacktrace -> (analyze-stacktrace err)

(So back to WIP - sorry for the noise @rrudakov)


Edit: note to self - analyze-stacktrace didn't work.

Next best approach is parsing runtime exceptions, just like we do for compile-time ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timbre logs can show in the minibuffer
1 participant