Avoid overlays and messages on stderr that is unrelated to exception handling

[vemv]

• Introduce cider-clojure-runtime-error-regexp
  • Similar to our compilation errors regex - we didn't need runtime-oriented ones till now
  • Ref
• Avoid overlays and messages on stderr that is unrelated to exception handling
  • Fixes Timbre logs can show in the minibuffer #3587

After #3608 and other attempts I'm finally confident about this solution - it's simple, robust and aligned with other similar solutions.

@rrudakov QAing would be most welcome.

Cheers - V

[rrudakov]

I've done a quick test with the minimal project. The problem is not reproducible. I'll also try to test it with real project for some time.

[rrudakov]

I've done a quick test with the minimal project. The problem is not reproducible. I'll also try to test it with real project for some time.

I still can see it on a real project:

But those are reflection warnings. I don't see timbre error logs in the overlay anymore. Not sure if it's an expected behaviour though.

I have the following in my user.clj:

(alter-var-root #'*warn-on-reflection* (constantly true))

nrepl messages:

(<--
  id         "4"
  session    "bb23f216-4dc0-4420-b48c-1df6be8e6b08"
  time-stamp "2024-02-01 16:46:40.763034000"
  err        "Performance warning, com/adgoji/mollie/client.clj:86:22 - ca..."
)
(<--
  id         "11"
  session    "bb23f216-4dc0-4420-b48c-1df6be8e6b08"
  time-stamp "2024-02-01 16:46:44.966841000"
  err        "Reflection warning, net/cgrand/xml.clj:85:4 - call to method..."
)

[rrudakov]

I'd say it's good enough for me, I only see those messages once after starting the REPL.

[vemv]

That was super useful. Thankfully we have a regex for reflection warnings, so it's an easy fix.

Commit incoming

[vemv]

Ready again

[rrudakov]

I've just checked, looks great now, reflection/performance warnings are also gone.