added function tap-current-value to inspector

[behrica]

This PR is a pre-requisite to work on clojure-emacs/cider#3311
It adds a new function to the inspector to tap> the current value.

This function would needed to be called in a new operation in the cider-nrepl middleware.

• The commits are consistent with our contribution guidelines
• You've added tests to cover your change(s)
• All tests are passing
• The new code is not generating reflection warnings
• You've updated the changelog (if adding/changing user-visible functionality)

[vemv]

LGTM!

Thanks for this one.

[behrica]

I have always a certain test failing, but already before my change:

FAIL in (classpath-resources-test) (classpath_test.clj:91)
Iterating classpath resources returns non-empty lists
[#object[java.net.URL 0x17240340 "file:/mnt/extHDD/sources/orchard/src-spec-alpha-2/src/main/clojure/"] ()]
expected: (seq entry)
  actual: (not (seq ()))

[behrica]

I have always a certain test failing, but already before my change:

FAIL in (classpath-resources-test) (classpath_test.clj:91)
Iterating classpath resources returns non-empty lists
[#object[java.net.URL 0x17240340 "file:/mnt/extHDD/sources/orchard/src-spec-alpha-2/src/main/clojure/"] ()]
expected: (seq entry)
  actual: (not (seq ()))

Got it, need to test via make test

[vemv]

I will add it, but I think we test the clojure.core/tap> function doing that, not the code of cider / orchard.

It can also be understood as "we're tapping the right value" i.e. the integration with tap is correct.

Will be merging+releasing after one last touch. Great work!

[behrica]

Is there something missing for this PR ?

[vemv]

Thanks for the ping!

Please fix the linting fault (per the CI checks) and I'll look at it again.

[behrica]

done

[behrica]

I made it a noop on older Clojure

[vemv]

Hey there!

Please fix the failing tests so that I can merge this.

Cheers - V

[behrica]

Done, now tests run all all Clojure versions

[bbatsov]

Thanks!