Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added function tap-current-value to inspector #167

Merged
merged 8 commits into from
Mar 6, 2023
Merged

added function tap-current-value to inspector #167

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9eec540
added function of `tap-current-value`
behrica Jan 31, 2023
fc4a80d
adressed review comments
behrica Feb 2, 2023
1b30a02
improved test with more complex vale
behrica Feb 4, 2023
550b521
reformated
behrica Feb 5, 2023
214b182
fixed indention
behrica Feb 21, 2023
ebff35c
skip test when Clojure does not support tap>
behrica Feb 21, 2023
734d47b
noop when tap> ism missing on older Clojure
behrica Feb 21, 2023
0a7de38
make test compile on older clojure
behrica Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/orchard/inspect.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
(java.lang.reflect Constructor Field Method Modifier)
(java.util List Map)))

;; Datafy and Nav are only available since Clojure 1.10
;; Datafy Nav and tap> are only available since Clojure 1.10
(require 'clojure.core.protocols)

(def ^:private datafy
Expand All @@ -25,6 +25,8 @@
(def ^:private nav
(misc/call-when-resolved 'clojure.core.protocols/nav))

(def ^:private maybe-tap>
(misc/call-when-resolved 'clojure.core/tap>))
;;
;; Navigating Inspector State
;;
Expand Down Expand Up @@ -174,7 +176,7 @@
(defn tap-current-value
"Tap the currently inspected value."
[inspector]
(tap> (:value inspector))
(maybe-tap> (:value inspector))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it a noop on older Clojure

(inspect-render inspector))

(declare inspector-value-string)
Expand Down