Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFE] Version subcommand #17

Closed
rsevilla87 opened this issue Jul 19, 2023 · 1 comment · Fixed by #22
Closed

[RFE] Version subcommand #17

rsevilla87 opened this issue Jul 19, 2023 · 1 comment · Fixed by #22
Labels
enhancement New feature or request

Comments

@rsevilla87
Copy link
Member

Is your feature request related to a problem? Please describe.
ingress-perf should be able to report the binary version with an version subcommand

Describe the solution you'd like

$ ingress-perf version
v1.4.1@<commit_id>
@rsevilla87 rsevilla87 added the enhancement New feature or request label Jul 19, 2023
@krishvoor
Copy link
Member

Hi @rsevilla87 I'd like to work on this.

krishvoor added a commit to krishvoor/ingress-perf that referenced this issue Jul 20, 2023
@krishvoor
Fixes cloud-bulldozer#17
0a412d0 
Allows users to prin ingress-perf version

Signed-off-by: Krishna Harsha Voora <krvoora@redhat.com>
@krishvoor krishvoor mentioned this issue Jul 20, 2023
Merged
7 tasks
rsevilla87 pushed a commit that referenced this issue Jul 24, 2023
@krishvoor
Allows users to print version (#22)
51430a1 
* Fixes #17

Allows users to prin ingress-perf version

Signed-off-by: Krishna Harsha Voora <krvoora@redhat.com>

* Refactor the changes

* Moves version.go to pkg/version

Signed-off-by: Krishna Harsha Voora <krvoora@redhat.com>

* Remove dupe sources

Signed-off-by: Krishna Harsha Voora <krvoora@redhat.com>

* Indexing Ingress-perf version number

---------

Signed-off-by: Krishna Harsha Voora <krvoora@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allows users to print version krishvoor/ingress-perf
2 participants
@rsevilla87 @krishvoor