-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows users to print version #22
Conversation
Allows users to prin ingress-perf version Signed-off-by: Krishna Harsha Voora <krvoora@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking over @krishvoor , added some somments.
cmd/ingress-perf.go
Outdated
Run: func(cmd *cobra.Command, args []string) { | ||
fmt.Printf("%s@%s \n", version.Version, version.GitCommit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would print as requested in the RFE
./bin/ingress-perf version
version-branch@0a412d04ae6690d95eec2b5aa740c794ae08b8f6
or would you like this to be printed like in the kube-burner?
kube-burner version
Version: 1.5
Git Commit: db331979da3447c210ce308a4c1d5e473ba7d440
Build Date: 2023-04-05T17:02:00Z
Go Version: go1.19.7
OS/Arch: darwin arm64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rsevilla87 can you ptal?
Signed-off-by: Krishna Harsha Voora <krvoora@redhat.com>
@krishvoor , thoughts on indexing the ingress-perf version number as well? you should be able to add it to the Result struct ingress-perf/pkg/runner/tools/types.go Lines 48 to 68 in 510d4ed
|
Signed-off-by: Krishna Harsha Voora <krvoora@redhat.com>
Yes, this would be useful in grafana reporting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Allows users to print ingress-perf version
Indexes the ingress-perf version into grafana reporting
Type of change
Description
Allows users to print ingress-perf version
Related Tickets & Documents
Checklist before requesting a review
Testing