Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ES instances to upgrade to gp3 volumes #341

Merged
merged 10 commits into from
Oct 10, 2023
Merged

Conversation

markdboyd
Copy link
Contributor

@markdboyd markdboyd commented Oct 6, 2023

Related to #339

Changes proposed in this pull request:

  • Add new volume_type option when updating Elasticsearch instances
  • Add validator for volume_type to only allow gp3 as a value
  • Add logic to set EBS volume type (if changed) when updating an Elasticsearch instance
  • Add new unit tests to cover new behavior

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

There are no other expected changes in functionality besides allowing users to set the volume_type to gp3 when running cf update-service on their Elasticsearch instances

@markdboyd markdboyd marked this pull request as ready for review October 6, 2023 19:11
@markdboyd markdboyd added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit 51c5060 Oct 10, 2023
2 checks passed
@markdboyd markdboyd deleted the allow-es-upgrade-gp3 branch October 10, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants