Code

MQTT-support#766

Code

Open

kickster97 wants to merge 200 commits intomaincloudamqp/lavinmq:mainfrom mqtt-poccloudamqp/lavinmq:mqtt-pocCopy head branch name to clipboard

+3,721-101

Commits

Commits on Dec 20, 2024

• beginning of mqtt-poc, ping

  

  kickster97

  authored and

  spuun

  committed
  8844846

• add send/recieve oct_count, make prometheus controller compile

  

  kickster97

  authored and

  spuun

  committed
  3e5d0ae

• client stores client_id and quick solution for UI

  

  kickster97

  authored and

  spuun

  committed
  217af7d

• amqp publish

  

  kickster97

  authored and

  spuun

  committed
  558f523

• mqtt integration spec: ping

  

  snichme

  authored and

  spuun

  committed
  7af0b72

• fixup! amqp publish

  

  kickster97

  authored and

  spuun

  committed
  5185a7f

• int-specs

  

  snichme

  authored and

  spuun

  committed
  29023a6

• cleanup

  

  snichme

  authored and

  spuun

  committed
  1aec0fd

• connect specs (pending)

  

  snichme

  authored and

  spuun

  committed
  9e08a10

• all integration specs (pending)

  

  snichme

  authored and

  spuun

  committed
  2cda54c

• Synchronizer -> channel

  

  snichme

  authored and

  spuun

  committed
  a5117c0

• spec: publish mqtt ends up in amqp queue

  

  snichme

  authored and

  spuun

  committed
  f246a02

• send puback after publish if qos > 0

  

  kickster97

  authored and

  spuun

  committed
  899491b

• publish will to session WIP

  

  kickster97

  authored and

  spuun

  committed
  8b6a740

• publish returns PubAck

  

  snichme

  authored and

  spuun

  committed
  e0fab76

• cleanup will preparation

  

  kickster97

  authored and

  spuun

  committed
  ea97018

• Got first working subscribe

  Show description for 5d48135
  

  snichme

  authored and

  spuun

  committed
  5d48135

• subscribe specs

  

  snichme

  authored and

  spuun

  committed
  7e0e458

• packet_id stuff

  

  snichme

  authored and

  spuun

  committed
  eb4f68a

• pass more connect specs

  

  kickster97

  authored and

  spuun

  committed
  e6fa800

• work on subscriber specs

  

  kickster97

  authored and

  spuun

  committed
  abc84ed

• start working on broker for clients

  

  kickster97

  authored and

  spuun

  committed
  7ac4d7e

• wrap vhost in broker for mqtt::client

  

  kickster97

  authored and

  spuun

  committed
  895f04c

• pass more specs and handle session_present

  

  kickster97

  authored and

  spuun

  committed
  d9b0049

• all connect specs working except replace client with new connection

  

  kickster97

  authored and

  spuun

  committed
  6e8e88c

• fix logs in client and dot expect connack in specs

  

  kickster97

  authored and

  spuun

  committed
  38add29

• add sessions to broker, and handle incoming subscribe with session

  

  kickster97

  authored and

  spuun

  committed
  252b877

• fixup! add sessions to broker, and handle incoming subscribe with session

  

  kickster97

  authored and

  spuun

  committed
  e0e6705

• fixup! fixup! add sessions to broker, and handle incoming subscribe with session

  

  kickster97

  authored and

  spuun

  committed
  f8d0975

• subscribe and bind a session

  

  kickster97

  authored and

  spuun

  committed
  fc5e496

• temp

  

  kickster97

  authored and

  spuun

  committed
  27fec23

• exchange.publish

  

  snichme

  authored and

  spuun

  committed
  fe946eb

• mqtt exchange

  

  snichme

  authored and

  spuun

  committed
  afeb618

• refactor mqtt session

  

  kickster97

  authored and

  spuun

  committed
  9ac6ef0

• add get method to prepare for qos 1

  

  kickster97

  authored and

  spuun

  committed
  755069f

• feel like this got ugly, but subscribe specs are now passing

  

  kickster97

  authored and

  spuun

  committed
  e114446

• cleanup old code and use session instead of queue

  

  kickster97

  authored and

  spuun

  committed
  994f579

• refctoring consumer handling, and handle msg acks better

  

  kickster97

  authored and

  spuun

  committed
  716add6

• move consumers deliver_loop to session, specs do not pass

  

  kickster97

  authored and

  spuun

  committed
  54b9daa

• cleanup

  

  kickster97

  authored and

  spuun

  committed
  81fdb58

• SubscriptionTree

  

  snichme

  authored and

  spuun

  committed
  436f838

• rebase main

  

  kickster97

  authored and

  spuun

  committed
  1cc8475

• format

  

  kickster97

  authored and

  spuun

  committed
  af88297

• override method

  

  snichme

  authored and

  spuun

  committed
  5bfdfc4

• string token specs

  

  snichme

  authored and

  spuun

  committed
  2963efe

• crystal 1.14 fixes

  

  snichme

  authored and

  spuun

  committed
  b45f48f

• subscription tree specs

  

  snichme

  authored and

  spuun

  committed
  cf63b7d

• beginning of puback

  

  kickster97

  authored and

  spuun

  committed
  994b539

• subscription tree specs

  

  snichme

  authored and

  spuun

  committed
  e802b00

• remove puts

  

  snichme

  authored and

  spuun

  committed
  b3d2ba2

• Use monkey patched IO::Buffered#peek(n) to ensure data exists

  spuun

  committed
  e286090

• It should return slice

  spuun

  committed
  2b92b10

• Add spec to verify positive size check

  spuun

  committed
  25c41ba

• Rename stuff in an attempt to make things more readable

  spuun

  committed
  d116ea3

• Refactor specs

  spuun

  committed
  d7ddf50

• Cleaner specs

  spuun

  committed
  459c907

• Update spec description

  spuun

  committed
  8c54a7b

• Fix condition when checking if enough data exists

  spuun

  committed
  afdede3

• Move data in existing buffer if needed

  spuun

  committed
  caff313

• Return what we got instead of rasing in read fails

  spuun

  committed
  2d7b8ae

• Remove unused code

  spuun

  committed
  10e640b

• merge jons pr and fix sleep problem

  

  kickster97

  authored and

  spuun

  committed
  ecb29fb

• spec fix for subtree

  

  snichme

  authored and

  spuun

  committed
  7479bc0

• set dup value when delivering a msg

  

  kickster97

  authored and

  spuun

  committed
  871b4c9

• cleanup

  

  kickster97

  authored and

  spuun

  committed
  578026c

• retain_store and topic_tree

  

  kickster97

  authored and

  spuun

  committed
  15b3020

• Restructure retain-store and topic_tree for better fit in LavinMQ

  Show description for d5791fa
  

  kickster97

  and

  spuun

  committed
  d5791fa

• publish retained message

  

  kickster97

  authored and

  spuun

  committed
  aaa76fe

• Update src/lavinmq/mqtt/retain_store.cr

  Show description for f6caf2f
  

  kickster97

  and

  spuun

  committed
  f6caf2f

• retained messages spec pass

  

  kickster97

  authored and

  spuun

  committed
  828241c

• Improve handling of non-clean sesssions

  Show description for fef4828
  spuun

  committed
  fef4828

• pass will specs

  

  kickster97

  authored and

  spuun

  committed
  a706d28

• cleanup

  

  kickster97

  authored and

  spuun

  committed
  e1b4592

• pass duplicate message specs

  

  kickster97

  authored and

  spuun

  committed
  e2837c4

• format

  

  kickster97

  authored and

  spuun

  committed
  927eead

• fix publish

  

  kickster97

  authored and

  spuun

  committed
  042615c

• remove obsolete header

  

  kickster97

  authored and

  spuun

  committed
  a142bfe

• cleanup

  

  kickster97

  authored and

  spuun

  committed
  087e472

• raise io error for invalid package_id

  

  kickster97

  authored and

  spuun

  committed
  dd0ad9a

• handle raise for double connect

  

  kickster97

  authored and

  spuun

  committed
  6e2a019

• revert double connect rescue

  

  kickster97

  authored and

  spuun

  committed
  da1fd5a

• Remove unused variable

  spuun

  committed
  a28071e

• Use method overloading instead of type check

  spuun

  committed
  4dc77ad

• Use lowercase log source

  spuun

  committed
  30d6656

• Use mqtt.session as log source for Session

  spuun

  committed
  e18ca81

• Add spec to test publisher->subscriber flow

  spuun

  committed
  9e16138

• Add spec to verify that session is restored properly

  spuun

  committed
  0695739

• Use getter instead of instance variable

  spuun

  committed
  5a8b74c

• beginning of max_inflight

  

  kickster97

  authored and

  spuun

  committed
  1fff3f6

• send in topic to subscription tree, pass specs

  

  kickster97

  authored and

  spuun

  committed
  297301f

• clean up

  

  kickster97

  authored and

  spuun

  committed
  1e7c463

• create publish packet in client instead of accepting will in #broker:publish

  

  kickster97

  authored and

  spuun

  committed
  db79181

• Be consistent with typing

  spuun

  committed
  d939010

• Add routing specs

  spuun

  committed
  360516f

• Lint

  spuun

  committed
  601dfe1

• Return nil and let spec assert

  spuun

  committed
  69a883c

• Add a will spec (and some clean up)

  spuun

  committed
  3cd1c4f

• publish will if PacketDecode exception

  

  kickster97

  authored and

  spuun

  committed
  4ccbc6f

• move vhost logic from client into broker

  

  kickster97

  authored and

  spuun

  committed
  8552f60

• Improve logging

  spuun

  committed
  a07b7e6

• add retain_store specs for .retain and .each

  

  kickster97

  authored and

  spuun

  committed
  a9e0edc

• No need to prefix class, use namespace

  spuun

  committed
  cab4bd0

• Update src/lavinmq/mqtt/client.cr

  Show description for 445b81a
  

  kickster97

  and

  spuun

  committed
  445b81a

• remove unnessecary socket.close

  

  kickster97

  authored and

  spuun

  committed
  afb7a67

• log warning instead of raise

  

  kickster97

  authored and

  spuun

  committed
  8b17658

• fetch max_inflight_messages form config

  

  kickster97

  authored and

  spuun

  committed
  2d17bf5

• Convert Publish to Message in exchange

  spuun

  committed
  e405a5a

• Less aggressive logging

  spuun

  committed
  34a7dff

• Suspend fiber while waiting for msg or consumer

  Show description for 83d535c
  spuun

  committed
  83d535c

• add specs for handling connect packets with empty client_ids

  

  kickster97

  authored and

  spuun

  committed
  9382640

• handle connect packets with empty client_id strings

  

  kickster97

  authored and

  spuun

  committed
  9fcf93c

• fixup! Suspend fiber while waiting for msg or consumer

  spuun

  committed
  8d66831

• Move Sessions to separate file

  spuun

  committed
  f79ef62

• Dont convert topic to routing key, and use topic all the way through

  

  kickster97

  authored and

  spuun

  committed
  bda50b0

• prefix sessions with mqtt. and do not let amqp queues create queues that start with .mqtt

  

  kickster97

  authored and

  spuun

  committed
  69013eb

• move validation to queue_factory and return preconditioned fail for amqp queues with .mqtt prefix

  

  kickster97

  authored and

  spuun

  committed
  07c4bb7

• prefix_validation wip

  

  kickster97

  authored and

  spuun

  committed
  0fc85bf

• delete old cherry-picked code, replaced with #818

  

  kickster97

  authored and

  spuun

  committed
  4f92325

• mqtt exchange receives MQTT::Publish but publish AMQP::Message to queue(session)

  

  snichme

  authored and

  spuun

  committed
  0b866a6

• remove obsolete spec

  

  kickster97

  authored and

  spuun

  committed
  06e702c

• format

  

  kickster97

  authored and

  spuun

  committed
  26aaac7

• rebase in abstrace queue

  

  kickster97

  authored and

  spuun

  committed
  cf87cc9

• adapt for queue abstraction

  

  kickster97

  authored and

  spuun

  committed
  6f9d5cf

• repain broken amqp specs

  

  kickster97

  authored and

  spuun

  committed
  880078b

• rename prefix validator to namevalidator and move valid_entity_name into it

  

  kickster97

  authored and

  spuun

  committed
  7a11f0c

• remove unnessecary allocation in #NameValidator.valid_prefix

  

  kickster97

  authored and

  spuun

  committed
  b0b6734

• cleanup ordering in connections js

  

  kickster97

  authored and

  spuun

  committed
  4b6b80e

• remove sessions from vhost, redundant

  

  kickster97

  authored and

  spuun

  committed
  0e540aa

• use default random instead of secure for client_id

  

  kickster97

  authored and

  spuun

  committed
  a2e90d0

• delete unreferences messages in retain store when building index

  

  kickster97

  authored and

  spuun

  committed
  7f28ef9

• move exchange into the mqtt namespace

  

  kickster97

  authored and

  spuun

  committed
  79589f7

• use mqtt namespace MqttBindingKey->BindingKey

  

  kickster97

  authored and

  spuun

  committed
  243308a

• remove redundant return value

  

  kickster97

  authored and

  spuun

  committed
  185e4a4

• update name validator

  

  kickster97

  authored and

  spuun

  committed
  552c9d2

• move unacked_messagesapi logic to queue and overload method in session

  

  kickster97

  authored and

  spuun

  committed
  60fdfb3

• format

  

  kickster97

  authored and

  spuun

  committed
  0231988

• update logs for name validation failures

  

  kickster97

  authored and

  spuun

  committed
  fbba9a0

• don't have risk of overwriting retain store msg files

  

  kickster97

  authored and

  spuun

  committed
  7570aee

• ensure to remove file

  

  kickster97

  authored and

  spuun

  committed
  70d7c33

• format

  

  kickster97

  authored and

  spuun

  committed
  3f68445

• replicate retain store, wip

  

  kickster97

  authored and

  spuun

  committed
  21b9aea

• add mqtts config + listener

  

  kickster97

  authored and

  spuun

  committed
  c0b9884

• format

  

  kickster97

  authored and

  spuun

  committed
  86c3ba9

• replication spec works correctly

  

  kickster97

  authored and

  spuun

  committed
  3df327c

• add mqtt_proxy for clustering client

  

  kickster97

  authored and

  spuun

  committed
  a86f4a3

• r+ needs file to exist before open

  

  kickster97

  authored and

  spuun

  committed
  08da5de

• format

  

  kickster97

  authored and

  spuun

  committed
  98d19d6

• fix ameba failures

  

  kickster97

  authored and

  spuun

  committed
  9fc71c5

• satisfy ameba for spec files

  

  kickster97

  authored and

  spuun

  committed
  54d5da5

• rename specfile with suffix

  

  kickster97

  authored and

  spuun

  committed
  e4578de

• fix flaky wait_for

  

  kickster97

  authored and

  spuun

  committed
  eb312af

• Use enum for protocol to get compile time validation

  spuun

  committed
  0474300

• Fix specs to use protocol enum

  spuun

  committed
  04444d7

• use short block notation

  

  kickster97

  authored and

  spuun

  committed
  c841059

• fix mqtt exchange routing spec

  

  snichme

  authored and

  spuun

  committed
  40b3768

• remove comment

  

  snichme

  authored and

  spuun

  committed
  d46f5bb

• scope fix

  

  snichme

  authored and

  spuun

  committed
  44bd650

• Multi-vhost support

  spuun

  committed
  cdc2c58

• expand details tuple for consumer UI

  

  kickster97

  authored and

  spuun

  committed
  e9263cd

• no need to convert routing key

  

  kickster97

  authored and

  spuun

  committed
  89b1827

• format

  

  kickster97

  authored and

  spuun

  committed
  e309e35

• handle unexpected close from client

  

  kickster97

  authored and

  spuun

  committed
  6e0941d

• connection_at for mqtt connections

  

  snichme

  authored and

  spuun

  committed
  dbb1592

• deliver packet not msg from session (#843)

  Show description for 4f2f7ed
  

  snichme

  authored and

  spuun

  committed
  4f2f7ed

• truncate the previous content before you retain a message

  

  kickster97

  authored and

  spuun

  committed
  5c4fda9

• safely overwrite retained messages

  

  kickster97

  authored and

  spuun

  committed
  c9cf5d3

• Cant use constant as key in NamedTuple

  spuun

  committed
  14a587a

• merge solutions for retain store

  

  kickster97

  authored and

  spuun

  committed
  5c2150a

• general fixup after comments

  

  kickster97

  authored and

  spuun

  committed
  9b3e5c7

• format

  

  kickster97

  authored and

  spuun

  committed
  cd7105c

• set flaky spec to pending

  

  kickster97

  authored and

  spuun

  committed
  c699a2f

• just a test

  

  kickster97

  authored and

  spuun

  committed
  ed33f08

• just a test

  

  kickster97

  authored and

  spuun

  committed
  d6265ac

• tmp: debug clustering_spec

  

  baelter

  authored and

  spuun

  committed
  00a8826

• finalize clustering spec

  

  kickster97

  authored and

  spuun

  committed
  b0995da

• use instance var for index file name

  

  kickster97

  authored and

  spuun

  committed
  888ce85

• rescue argumenterror in deliver loop

  

  kickster97

  authored and

  spuun

  committed
  af60d4a

• format

  

  kickster97

  authored and

  spuun

  committed
  2f9b881

• Fix mqtt unix listener (and some logging)

  spuun

  committed
  32f0199

• Prevent Channel::Closed error from being raised

  spuun

  committed
  28a8fa0

• exception handling for mqtt default bindings

  

  kickster97

  authored and

  spuun

  committed
  167e8d6

• only allow selected policies to be applied for mqtt session

  

  kickster97

  authored and

  spuun

  committed
  de47c28

• handle qos 2 at build_packet

  

  kickster97

  authored and

  spuun

  committed
  9580e71

• dont allow amqp queues or exchanges to bind to mqtt queues or exchanges

  

  kickster97

  authored and

  spuun

  committed
  ee5ff51

Commits on Dec 23, 2024

• forbidden to bind AMQP excahnges to the MQTT Session

  

  kickster97

  authored and

  spuun

  committed
  5825665

• format

  

  kickster97

  authored and

  spuun

  committed
  ccde2e2

• clean up review comments

  

  kickster97

  authored and

  spuun

  committed
  3709074

• initialize @broekrs in server instead of in connection_factory

  

  kickster97

  authored and

  spuun

  committed
  1397c83

• version bump

  

  viktorerlingsson

  authored and

  spuun

  committed
  ecbfd30

• Rescue IndexError in first? and move on to next segment (#864)

  Show description for 5fb5e8b
  

  viktorerlingsson

  authored and

  spuun

  committed
  5fb5e8b

• java-client dont redeclare exchange in spec (#860)

  Show description for fa2531e
  

  viktorerlingsson

  authored and

  spuun

  committed
  fa2531e

• fetch max_inflight_messages form config

  

  kickster97

  authored and

  spuun

  committed
  e9b29da

• clean up for review comments

  

  kickster97

  authored and

  spuun

  committed
  b0e8e12

• Fix some logging

  spuun

  committed
  e040b58

• log nr of streamed bytes every 30 seconds in follower (#885)

  Show description for 8d39a10
  

  viktorerlingsson

  authored and

  spuun

  committed
  8d39a10

• Update src/lavinmq/mqtt/session.cr

  Show description for 151c82f
  

  kickster97

  and

  spuun

  committed
  151c82f

• review fix

  

  kickster97

  authored and

  spuun

  committed
  8bde3ba

• remove excess write and rewind in exchange

  

  kickster97

  authored and

  spuun

  committed
  ed141ca

• Fix spec compilation

  spuun

  committed
  68a5494

• Prevent MQTT entities to be bound to AMQP exchanges

  Show description for 49aa426
  spuun

  committed
  49aa426