Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added workflow for cloudformation linter and security scan #83

Merged
merged 13 commits into from
Sep 27, 2023
Merged

feat: Added workflow for cloudformation linter and security scan #83

merged 13 commits into from
Sep 27, 2023

Conversation

VishwajitNagulkar
Copy link
Member

@VishwajitNagulkar VishwajitNagulkar commented Sep 27, 2023 •
edited
Loading

what

  • Added workflow for cloudformation linter and security scan
  • made yml linter workflow reusable
  • Added TF var access token in environment variables
  • Added attribute for minimum-approval in terraform workflow acceptace step

@VishwajitNagulkar VishwajitNagulkar requested a review from a team September 27, 2023 11:48
d4kverma
d4kverma approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@d4kverma d4kverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikitadugar nikitadugar merged commit bb25820 into master Sep 27, 2023
@nikitadugar nikitadugar deleted the internal_560 branch September 27, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitadugar nikitadugar nikitadugar approved these changes

@d4kverma d4kverma d4kverma approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VishwajitNagulkar @nikitadugar @d4kverma