Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added workflow for cloudformation linter and security scan #83

Merged
merged 13 commits into from
Sep 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions .github/workflows/cf-lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
---
name: cloudformation-linter
on:
workflow_call:
inputs:
cf_file_path:
required: true
type: string
description: 'path of cloudformation template.'

jobs:
cloudformation-linter:
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v4

- name: cfn-lint-action
uses: ScottBrenner/cfn-lint-action@v2
with:
command: cfn-lint -t ${{ inputs.cf_file_path }}

- name: cfn security checks
uses: minchao/cfn-nag-action@v0.1
with:
args: '--input-path ${{ inputs.cf_file_path }}'
...
11 changes: 11 additions & 0 deletions .github/workflows/terraform_workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ on:
type: number
default: 10
description: 'Timeout for approval step'
minimum-approvals:
required: false
type: string
default: 1
description: 'Minimum approvals required to accept the plan'
secrets:
AZURE_CREDENTIALS:
required: false
Expand Down Expand Up @@ -73,6 +78,9 @@ on:
SPACES_SECRET_ACCESS_KEY:
required: false
description: 'Spaces secret access key for digitalocean if required'
TF_VAR_access_token:
required: false
description: 'TF var access token'

jobs:
terraform-workflow:
Expand All @@ -82,6 +90,8 @@ jobs:
DIGITALOCEAN_TOKEN: ${{ secrets.DIGITALOCEAN_ACCESS_TOKEN }}
SPACES_ACCESS_KEY_ID: ${{ secrets.SPACES_ACCESS_KEY_ID }}
SPACES_SECRET_ACCESS_KEY: ${{ secrets.SPACES_SECRET_ACCESS_KEY }}
TF_VAR_access_token: ${{ secrets.TF_VAR_access_token }}

outputs:
tfplanExitCode: ${{ steps.tf-plan.outputs.exitcode }}

Expand Down Expand Up @@ -193,6 +203,7 @@ jobs:
with:
secret: ${{ github.TOKEN }}
approvers: ${{ inputs.approvers }}
minimum-approvals: ${{ inputs.minimum-approvals }}
issue-title: "Terraform Plan for Infrastructure Update"

- name: terraform apply
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/ymllint-internal.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
name: YAML-LINTER
on: [pull_request]

jobs:
YAML-LINTER:
uses: clouddrove/github-shared-workflows/.github/workflows/ymllint.yml@master
...
7 changes: 4 additions & 3 deletions .github/workflows/ymllint.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
---
name: Yaml Lint
on: [pull_request]
name: YAML-LINTER
on:
workflow_call:
jobs:
Yaml-Lint:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -41,7 +42,7 @@ jobs:
empty-lines:
level: error
empty-values:
level: error
level: warning
float-values:
level: error
hyphens:
Expand Down
4 changes: 4 additions & 0 deletions docs/terraform_workflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
var_file: # name of tfvar file e.g "variable.tfvar"
aws_region: # specify region eg. us-east-2
approvers: # Assignee name for approve apply or destroy step
minimum-approvals: # Minimum number of approvals required to progress the workflow, deafault value is 1
terraform_version: # Specify terraform version e.g 1.3.6
destroy: # If the value is set to true, the workflow proceeds to the destroy step. However, the default value is false
secrets:
Expand All @@ -49,6 +50,7 @@ jobs:
working_directory: # Specify terraform code directory in repo
var_file: # Name of tfvar file e.g "variable.tfvar"
approvers: # Assignee name for approve apply or destroy step
minimum-approvals: # Minimum number of approvals required to progress the workflow, deafault value is 1
terraform_version: # Specify terraform version e.g 1.3.6
destroy: # If the value is set to true, the workflow proceeds to the destroy step. However, the default value is false
secrets:
Expand All @@ -72,6 +74,7 @@ jobs:
working_directory: # Specify terraform code directory in repo
var_file: # Name of tfvar file e.g "variable.tfvar"
approvers: # Assignee name for approve apply or destroy step
minimum-approvals: # Minimum number of approvals required to progress the workflow, deafault value is 1
terraform_version: # Specify terraform version e.g 1.3.6
destroy: # If the value is set to true, the workflow proceeds to the destroy step. However, the default value is false
secrets:
Expand All @@ -97,6 +100,7 @@ jobs:
working_directory: # Specify terraform code directory in repo
var_file: # Name of tfvar file e.g "variable.tfvar"
approvers: # Assignee name for approve apply or destroy step
minimum-approvals: # Minimum number of approvals required to progress the workflow, deafault value is 1
terraform_version: # Specify terraform version e.g 1.3.6
destroy: # If the value is set to true, the workflow proceeds to the destroy step. However, the default value is false
secrets:
Expand Down