Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client Mutates Events When Modifying Extensions #350

Closed
ian-mi opened this issue Mar 6, 2020 · 0 comments · Fixed by #352
Closed

Client Mutates Events When Modifying Extensions #350

ian-mi opened this issue Mar 6, 2020 · 0 comments · Fixed by #352

Comments

@ian-mi
Copy link
Contributor

ian-mi commented Mar 6, 2020

Instead of modifying the caller's copy the client should clone the event context before setting event extensions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clone event context before setting the distributed tracing extension ian-mi/sdk-go
1 participant
@ian-mi