Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone event context before setting the distributed tracing extension #352

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

ian-mi
Copy link
Contributor

@ian-mi ian-mi commented Mar 6, 2020

This prevents the client from mutating the caller's copy of the event
allowing for sharing across multiple clients.

Fixes #350

This prevents the client from mutating the caller's copy of the event
allowing for sharing across multiple clients.

Signed-off-by: Ian Milligan <ianmllgn@gmail.com>
@ian-mi ian-mi force-pushed the client-copy-ctx branch from 1521d7e to 337cfe4 Compare March 6, 2020 04:46
@n3wscott
Copy link
Member

n3wscott commented Mar 6, 2020

LGTM

@n3wscott n3wscott merged commit 8a01634 into cloudevents:master Mar 6, 2020
@ian-mi ian-mi deleted the client-copy-ctx branch March 6, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client Mutates Events When Modifying Extensions
2 participants