Clone event context before setting the distributed tracing extension #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-mi
force-pushed
the
client-copy-ctx-v1
branch
from
5f98a88 to
ea72bed
Compare
This prevents the client from mutating the caller's copy of the event allowing for sharing across multiple clients. Signed-off-by: Ian Milligan <ianmllgn@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
ian-mi
force-pushed
the
client-copy-ctx-v1
branch
from
ea72bed to
8172a8e
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the client from mutating the caller's copy of the event
allowing for sharing across multiple clients. Also includes a cherry pick of PR #333 to fix event context Clone()
Backports fix for #350.