Fixed #332 #333
Merged
Fixed #332 #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n3wscott
reviewed
Mar 3, 2020
slinkydeveloper
force-pushed
the
eventcontext_clone
branch
from
f8f769f to
7798b42
Compare
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper
force-pushed
the
eventcontext_clone
branch
from
7798b42 to
94399db
Compare
|
LGTM Thanks! |
|
LGTM |
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
ian-mi
pushed a commit
to ian-mi/sdk-go
that referenced
this pull request
Mar 6, 2020
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
ian-mi
pushed a commit
to ian-mi/sdk-go
that referenced
this pull request
Mar 6, 2020
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
ian-mi
pushed a commit
to ian-mi/sdk-go
that referenced
this pull request
Mar 6, 2020
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
n3wscott
pushed a commit
that referenced
this pull request
Mar 6, 2020
…351) * Fixed #332 (#333) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Clone event context before setting the distributed tracing extension This prevents the client from mutating the caller's copy of the event allowing for sharing across multiple clients. Signed-off-by: Ian Milligan <ianmllgn@gmail.com> Co-authored-by: Francesco Guardiani <francescoguard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #332, now the
Clone()method copies the extensions mapSigned-off-by: Francesco Guardiani francescoguard@gmail.com