Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error deleting attributes when writing to HTTP messages #557

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Fix error deleting attributes when writing to HTTP messages #557

merged 1 commit into from
Jul 27, 2020

Conversation

ian-mi
Copy link
Contributor

@ian-mi ian-mi commented Jul 25, 2020

Transformers which delete attributes currently fail when writing a binary message to an HTTP request with the error "invalid CloudEvents value: ".

@ian-mi
Fix error deleting attributes when writing to HTTP messages
33cae3e 
Signed-off-by: Ian Milligan <ianmllgn@gmail.com>
@slinkydeveloper slinkydeveloper added bug Something isn't working component/protocol/http labels Jul 27, 2020
@slinkydeveloper slinkydeveloper merged commit 52b184c into cloudevents:master Jul 27, 2020
@slinkydeveloper
Copy link
Member

Thanks!

@ian-mi ian-mi deleted the http-delete-attribute branch July 27, 2020 17:50
@ian-mi ian-mi mentioned this pull request Jul 27, 2020
Merged
@slinkydeveloper slinkydeveloper added this to the SDK 2.2 milestone Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working component/protocol/http
Projects
None yet
Milestone
SDK 2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-mi @slinkydeveloper