-
Notifications
You must be signed in to change notification settings - Fork 74
Use transformer to avoid making unnecessary event copy in delivery transformer #1514
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ian-mi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fbb22bf
to
942cb00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up so quick. Left a nit.
942cb00
to
5b7b61c
Compare
Event messages are not immutable so I had to introduce an immutable version to avoid the event copy. This happened to expose a bug in the HTTP message implementation which I fixed upstream in cloudevents/sdk-go#557. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Left a question
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The following is the coverage report on the affected files.
|
/retest |
The following jobs failed:
Automatically retrying due to test flakiness... |
When sending to a retry topic it is still necessary to clone EventContext since the retry client
does not yet use message bindings.
Fixes #1511
Benchmark results show significant improvement for large payload sizes since this avoids buffering payload data: