Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove node 12 and node 14 #545

Merged
merged 2 commits into from
May 3, 2023

Conversation

lholmquist
Copy link
Contributor

Node 12 has been EOL since the end of April 2022 and Node 14 just became EOL at the end of April 2023

This is a major version bump

@lholmquist
Copy link
Contributor Author

@lance ^^

Node 12 has been EOL since the end of April 2022 and Node 14 just became EOL at the end of April 2023

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lance
Copy link
Member

lance commented May 3, 2023

@lholmquist it looks like the error message thrown with JSON parsing changed in v20. Can you also modify the expectation on line 59 of test/integration/parser_test.ts and remove the text validation?

    expect(parser.parse.bind(parser, payload)).to.throw(SyntaxError);

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist
Copy link
Contributor Author

@lance updated and looks like it passes now.

Hopefully this also generates a release pr 🤞

@lance lance merged commit 2cb9364 into cloudevents:main May 3, 2023
@lholmquist lholmquist deleted the remove_node_12_14 branch May 3, 2023 15:11
@lance lance mentioned this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants