Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI vs URI-reference #384

Closed
n3wscott opened this issue Feb 5, 2019 · 2 comments · Fixed by #386
Closed

URI vs URI-reference #384

n3wscott opened this issue Feb 5, 2019 · 2 comments · Fixed by #386

Comments

@n3wscott
Copy link
Member

n3wscott commented Feb 5, 2019

Found an issue when URI was changed to be URI-reference, the definition of URI was removed but the usage of URI remains in schemaurl.

see https://github.com/cloudevents/spec/blob/master/spec.md#schemaurl for usage of URI

@cneijenhuis
Copy link
Contributor

Good catch, that was me in #338.

I think I started looking for usages of URI in the Swagger/JSON schema - which doesn't contain schemaurl at the moment - and, as I only found source, changed only that in spec.md.

I'll clean that up, and also add schemaurl to spec.json.

Thanks!

@cneijenhuis
Copy link
Contributor

Correction: schemaurl has already been added to spec.json yesterday via #372 😉

Opened #386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants