Rename URI to URI-reference, fix JSON Schema #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duglin
reviewed
Nov 2, 2018
documented-extensions.md
Outdated
| `Number`) document their `Value` and structured types document their | ||
| `Attributes`. | ||
| As a convention, extensions of scalar types (e.g. `String`, `Binary`, | ||
| `URI-refernce`, `Number`) document their `Value` and structured types document |
|
thanks!!! |
Signed-off-by: Christoph Neijenhuis <christoph.neijenhuis@commercetools.de>
cneijenhuis
force-pushed
the
clarify-uri-reference
branch
from
710f473 to
31850e1
Compare
|
Yes, it meant to do that. We had a lengthy debate about it these being URI references but that got lost in time. LGTM |
|
Approved on Nov 8 call |
This was referenced Feb 5, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #332, we figured out that the spec actually meant to support URI-references all along. However, by defining the type as
URI, it is easy to make a mistake and assume it is only a URI, not a URI-reference.This mistake was also made in the JSON Schema.
This PR therefore does three things:
URI-reference, in order to make it easier to grasp for others in the futureThe main changes are in
spec.mdandspec.json.Signed-off-by: Christoph Neijenhuis christoph.neijenhuis@commercetools.de