Consistency: schemaurl uses URI-reference, protobuf uses URI-reference #386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #384
In #169 it was decided that inside the specification, we only use
URI-reference
. (From reading the PR, it is not clear to me whether it was intended to change bothschemaurl
andsource
, or onlysource
, but the PR effectively changed both).In #338 I renamed the shorthand
URI
toURI-reference
, because it was easy to wrongly assume only URIs are supported, but not URI references.I missed changing the
schemaurl
type.When
schemaurl
was introduced tospec.json
, that was mixed up as well.Related, the
protobuf-format.md
type mapping wasn't consistent with the type naming inspec.md
(I think both PRs ran concurrently), which I'm fixing as well.There is probably a discussion to be had whether #169 actually intended to change
schemaurl
- the constraint suggests otherwise - and if we want to have bothURI
andURI-reference
in the type system.Signed-off-by: Christoph Neijenhuis christoph.neijenhuis@commercetools.de