Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency: schemaurl uses URI-reference, protobuf uses URI-reference #386

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

cneijenhuis
Copy link
Contributor

Closes #384

In #169 it was decided that inside the specification, we only use URI-reference. (From reading the PR, it is not clear to me whether it was intended to change both schemaurl and source, or only source, but the PR effectively changed both).

In #338 I renamed the shorthand URI to URI-reference, because it was easy to wrongly assume only URIs are supported, but not URI references.
I missed changing the schemaurl type.
When schemaurl was introduced to spec.json, that was mixed up as well.

Related, the protobuf-format.md type mapping wasn't consistent with the type naming in spec.md (I think both PRs ran concurrently), which I'm fixing as well.


There is probably a discussion to be had whether #169 actually intended to change schemaurl - the constraint suggests otherwise - and if we want to have both URI and URI-reference in the type system.

Signed-off-by: Christoph Neijenhuis christoph.neijenhuis@commercetools.de

Signed-off-by: Christoph Neijenhuis <christoph.neijenhuis@commercetools.de>
@cneijenhuis cneijenhuis mentioned this pull request Feb 5, 2019
@duglin
Copy link
Collaborator

duglin commented Feb 7, 2019

Approved on the 2/7 call.

@duglin duglin merged commit 8786d0e into cloudevents:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URI vs URI-reference
2 participants