-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kafka spec] Conflicting sentences in message mapping #812
Comments
slinkydeveloper
added a commit
to slinkydeveloper/spec
that referenced
this issue
Apr 19, 2021
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper
added a commit
to slinkydeveloper/spec
that referenced
this issue
Apr 19, 2021
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Proposals to fix (we should accept one of the two):
In theory both proposals are breaking in the spec sense, but I'm not aware of any (sdk) implementing the actual spec text properly, but rather they all implement the #813 behaviour. |
@duglin can we close this one? |
slinkydeveloper
added a commit
to slinkydeveloper/spec
that referenced
this issue
May 17, 2021
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> (cherry picked from commit ca5bc52) Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
ok looks like we can close this one since #813 was merged. Let me know if I'm mistaken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In message mapping paragraph we have 2 sentences:
My interpretation is the following:
This logic is the same as every other protocol binding spec we have. But then, a couple of lines below, we have this sentence:
This is in contrast with the above sentence, because if the content type is not present, following the above pseudocode, i should fall in the second branch.
I suspect this second sentence was placed to make the behaviour more kafkesque, because in kafka the content-type of a topic is usually known at-priory and using content-type header is not really kafka-idiomatic
The text was updated successfully, but these errors were encountered: