[Kafka spec] Fix the sentences conflict #814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
duglin
reviewed
Apr 29, 2021
|
|
||
| If the `content-type` header is not present then the receiver uses _structured_ | ||
| mode with the JSON event format. | ||
| When the `content-type` header value is present but is not prefixed with the |
There was a problem hiding this comment.
I think other specs have similar language, if we adopt this then we should probably change those too, right?
There was a problem hiding this comment.
Look at this comment for more details: #812 (comment)
This particular PR is more "kafkesque" as approach, so for this particular point, it diverges a bit from other protocol bindings
|
closing in favor of #813 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look at issue #812 for more details
Signed-off-by: Francesco Guardiani francescoguard@gmail.com