Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update geo_restrictions to be a pointer in the response struct #1244

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

nickysemenza
Copy link
Member

@nickysemenza nickysemenza commented Mar 23, 2023

Description

it's already a pointer in the request struct (ZoneCustomSSLOptions)

noticed this while working on cloudflare/terraform-provider-cloudflare#2319 but this isn't a requirement for that.

Has your change been tested?

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented (api.cloudflare.com or developers.cloudflare.com) and stable APIs.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2023

changelog detected ✅

@nickysemenza nickysemenza marked this pull request as ready for review March 23, 2023 20:05
@jacobbednarz
Copy link
Member

sorry @nickysemenza i attempted to get this one updated for you but your fork doesn't allow maintainers to push back changes. here is the diff to get everything going.

diff --git .changelog/1244.txt .changelog/1244.txt
new file mode 100644
index 0000000..f1a24e9
--- /dev/null
+++ .changelog/1244.txt
@@ -0,0 +1,3 @@
+```release-note:enhancement
+ssl: make `GeoRestrictions` a pointer inside of ZoneCustomSSL
+```
diff --git ssl_test.go ssl_test.go
index 78dd510..ea43e63 100644
--- ssl_test.go
+++ ssl_test.go
@@ -64,7 +64,7 @@ func TestCreateSSL(t *testing.T) {
                Signature:       "SHA256WithRSA",
                Status:          "active",
                BundleMethod:    "ubiquitous",
-               GeoRestrictions: ZoneCustomSSLGeoRestrictions{Label: "us"},
+               GeoRestrictions: &ZoneCustomSSLGeoRestrictions{Label: "us"},
                ZoneID:          "023e105f4ecef8ad9ca31a8372d0c353",
                UploadedOn:      uploadedOn,
                ModifiedOn:      modifiedOn,
@@ -266,7 +266,7 @@ func TestUpdateSSL(t *testing.T) {
                Signature:       "SHA256WithRSA",
                Status:          "active",
                BundleMethod:    "ubiquitous",
-               GeoRestrictions: ZoneCustomSSLGeoRestrictions{Label: "us"},
+               GeoRestrictions: &ZoneCustomSSLGeoRestrictions{Label: "us"},
                ZoneID:          "023e105f4ecef8ad9ca31a8372d0c353",
                UploadedOn:      uploadedOn,
                ModifiedOn:      modifiedOn,

…like in the request struct

noticed this while working on cloudflare/terraform-provider-cloudflare#2319 but this isn't a requirement for that.
@nickysemenza nickysemenza force-pushed the nicky/custom-ssl-geo branch from 0648b89 to c123331 Compare March 28, 2023 15:55
@jacobbednarz jacobbednarz merged commit b810d2e into cloudflare:master Mar 28, 2023
@github-actions github-actions bot added this to the v0.64.0 milestone Mar 28, 2023
github-actions bot pushed a commit that referenced this pull request Mar 28, 2023
@github-actions
Copy link
Contributor

This functionality has been released in v0.64.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants