when geo_restrictions aren't set, set as nil and not empty string #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
previously, we would send `geo_restrictions":{"label":""}`, now we won't send anything at all.
Resolves cloudflare#2318
```release-note:bug
resource/cloudflare_custom_ssl: fix json sent to API when geo_restrictions are not used (cloudflare#1472, cloudflare#2318)
```
nickysemenza
added a commit
to nickysemenza/cloudflare-go
that referenced
this pull request
Mar 23, 2023
…like in the request struct noticed this while working on cloudflare/terraform-provider-cloudflare#2319 but this isn't a requirement for that.
9 tasks
nickysemenza
force-pushed
the
nicky/custom-cert-no-geo
branch
from
5778016 to
07a8305
Compare
|
note that there is this test here: https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/internal/sdkv2provider/resource_cloudflare_custom_ssl_test.go#L113 but the API returns the same value regardless of if you send empty string or nil (before/after) this change, so we have an internal ticket to adjust that. |
|
acceptance tests all look good |
nickysemenza
added a commit
to nickysemenza/cloudflare-go
that referenced
this pull request
Mar 28, 2023
…like in the request struct noticed this while working on cloudflare/terraform-provider-cloudflare#2319 but this isn't a requirement for that.
|
This functionality has been released in v4.3.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, we would send
geo_restrictions":{"label":""}, now we won't send anything at all.Closes #2318
Closes #1472