Merge pull request #2319 from nickysemenza/nicky/custom-cert-no-geo

when geo_restrictions aren't set, set as nil and not empty string
cloudflare · Mar 24, 2023 · cc59935 · cc59935
2 parents 1164aca + e1a65cc
commit cc59935
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.changelog/2319.txt b/.changelog/2319.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+resource/cloudflare_custom_ssl: fix json sent to API when geo_restrictions are not used
+```
diff --git a/internal/sdkv2provider/resource_cloudflare_custom_ssl.go b/internal/sdkv2provider/resource_cloudflare_custom_ssl.go
@@ -245,8 +245,12 @@ func expandToZoneCustomSSLOptions(ctx context.Context, d *schema.ResourceData) (
 			for id, value := range cert.(map[string]interface{}) {
 				var newValue interface{}
 				if id == "geo_restrictions" {
-					newValue = cloudflare.ZoneCustomSSLGeoRestrictions{
-						Label: value.(string),
+					if value == "" {
+						newValue = nil
+					} else {
+						newValue = cloudflare.ZoneCustomSSLGeoRestrictions{
+							Label: value.(string),
+						}
 					}
 				} else {
 					newValue = value.(string)