[miniflare D1] replaces returnsData in statement with a natively supported function

[jschlesser]

I would like to point out that while this PR simplifies the codebase and makes it less fragile and implements the actual intent and is probably better for the longer term, it may not be the exact same behavior. However, its not dependent on an error message changing and it will avoid issues arising from TypeError not working working with instanceof comparisons in certain uses of the vm api to execute code. Also D1 is technically beta 🤷

[changeset-bot]

⚠️ No Changeset found

Latest commit: beb935b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[jschlesser]

References this issue

[jschlesser]

Also note that this property is a direct pass through to the native sqlite returns_data method
source code reference

The original D1 miniflare returnsData method could technically throw an exception, It's not clear to me that this patch ever would.

[mrbbot]

Hey! 👋 Thanks so much for the PR! This is exactly what we were looking for! 😃

it may not be the exact same behavior.

I'm not too concerned about that here, as you point out D1 isn't stable yet so we have flexibility.