[Miniflare 3] Re-implement D1 gateway using new storage system #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mrbbot
changed the title
penalosa
requested changes
May 4, 2023
| @@ -3,7 +3,7 @@ import fs from "fs/promises"; | |||
| import os from "os"; | |||
| import path from "path"; | |||
| import { performance } from "perf_hooks"; | |||
| import { Database as DatabaseType, Statement } from "better-sqlite3"; | |||
| import { Database as DatabaseType } from "better-sqlite3"; | |||
packages/tre/src/storage2/sql.ts
Outdated
| @@ -13,7 +13,7 @@ export type TypedStatement< | |||
| }; | |||
|
|
|||
| export type TypedDatabase = Omit<Database, "prepare"> & { | |||
| prepare<Params, SingleResult = unknown>( | |||
| prepare<Params = any[], SingleResult = unknown>( | |||
penalosa
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #555, and re-implements the D1 gateway using the new storage system. This also brings forward changes #533 and #544 from Miniflare 2, fixing those issues in Miniflare 3 as well. 🙂
Closes DEVX-591