Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated 'publish' with 'deploy' #101

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CyberFlameGO
Copy link

No description provided.

@CyberFlameGO CyberFlameGO requested a review from a team as a code owner September 20, 2023 21:18
src/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Simon Manning <367343+QuaqSim@users.noreply.github.com>
@barrenechea
Copy link

@WalshyDev @GregBrimble could you consider reviewing/merging this PR? I appreciate any help you can provide.

Copy link
Contributor

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasikpark
Copy link
Contributor

Run cloudflare/pages-action@v1.5.0
npm WARN exec The following package was not found and will be installed: wrangler@2.20.1
npm WARN deprecated rollup-plugin-inject@3.0.2: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-inject.
npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead
Delegating to locally-installed wrangler@3.15.0 over global wrangler@2.20.1...
Run `npx wrangler pages publish dist --project-name=www-defined --branch=update-deploy-script` to use the local version directly.

▲ [WARNING] `wrangler pages publish` is deprecated and will be removed in the next major version.

  Please use `wrangler pages deploy` instead, which accepts exactly the same arguments.


✨ Compiled Worker successfully
Uploading... (641/644)
Uploading... (642/644)
Uploading... (643/644)
Uploading... (644/644)
✨ Success! Uploaded 3 files (641 already uploaded) (1.66 sec)

✨ Uploading _headers
✨ Uploading _redirects
✨ Uploading Functions bundle

I'd love to eliminate this deprecation warning in my deploy logs

@albbus-stack
Copy link

Same as #118 this also fails to comply to a deprecation warning, this time an internal one from wrangler itself. This needs to be merged 😟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants