Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nodejs deprecated warning #118

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

riderx
Copy link

@riderx riderx commented Jan 25, 2024

This Pr fix the issue about deprecated warning reference from #117

@riderx riderx requested a review from a team as a code owner January 25, 2024 17:16
@cagataygurturk
Copy link

Any ETA for its release?

@andykenward
Copy link

@riderx can we also update the build cli esbuild target from es2021 to node20?

From

"build": "npx esbuild src/index.ts --bundle --platform=node --target=es2021 --outfile=index.js",

To

"build": "npx esbuild src/index.ts --bundle --platform=node --target=node20 --outfile=index.js",

@albbus-stack
Copy link

This is not that big of a deal and it should have been already merged to comply with the deprecation 😢

Copy link

@Goooler Goooler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you can update the description to

Closes #117.

That issue will be closed once this PR gets merged.

@benminer
Copy link

Any reason this hasn't been merged yet?

@Fabio1988
Copy link

what's the blocker of this?

@riderx
Copy link
Author

riderx commented Jul 8, 2024

Thanks @andykenward i modified it!
I'm not a core contributor, so I cannot do much more than a PR

@riderx
Copy link
Author

riderx commented Jul 8, 2024

Maybe @WalshyDev if you can report internally it, it would be super nice <3

@WalshyDev
Copy link
Member

cc: @cloudflare/banda-team

@andykenward
Copy link

andykenward commented Jul 9, 2024

Also need to update @types/node to 20. Plus we can remove the usage of the NPM package "undici" for fetch as Node.js 20 supports fetch natively.

https://nodejs.org/docs/latest-v20.x/api/globals.html#fetch

@Chemaclass
Copy link

What is preventing merging this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.