Adds ciphers to zone settings override

[riuvshyn]

Adds zone settings override for ciphers: https://api.cloudflare.com/#zone-settings-change-ciphers-setting

Also I've noticed that client/v4/zones/.../settings returns some more options that are not available in terraform:

{
  "result": [

...

    {
      "id": "ciphers",
      "value": [],
      "modified_on": null,
      "editable": true
    },

...

    {
      "id": "edge_cache_ttl",
      "value": 7200,
      "modified_on": null,
      "editable": true
    },

...

    {
      "id": "orange_to_orange",
      "value": "off",
      "modified_on": null,
      "editable": true
    },

...

    {
      "id": "visitor_ip",
      "value": "on",
      "modified_on": null,
      "editable": true
    },

...

  ],
  "success": true,
  "errors": [],
  "messages": []
}

Should I also add visitor_ip, orange_to_orange, edge_cache_ttl settings? Also I do not see anything for these settings in the docs...

[jacobbednarz]

Can you please split this into two separate PRs? The changes are not related and should be reviewed separately.

[riuvshyn]

@jacobbednarz sure, thanks for looking into this
probe_zone change is here: #903

Also can you please comment on my question in description about visitor_ip, orange_to_orange, edge_cache_ttl attributes that returned by API? I am struggling to find any documentation related to these

[jacobbednarz]

Should I also add visitor_ip, orange_to_orange, edge_cache_ttl settings?

I'll confirm about these first two however edge_cache_ttl was removed in #653. I'm assuming they are enterprise only features too which will make the pool of who will be using them smaller again.

[jacobbednarz]

This test is failing due to the setting not being persisted to state.

=== RUN   TestAccCloudflareZoneSettingsOverride_Full
    testing.go:705: Step 1 error: Check failed: Check 8/8 error: cloudflare_zone_settings_override.test: Attribute 'settings.0.ciphers' not found
--- FAIL: TestAccCloudflareZoneSettingsOverride_Full (21.01s)
FAIL
FAIL	github.com/cloudflare/terraform-provider-cloudflare/cloudflare	21.386s
FAIL

Check out the README for running these integration tests if you haven't already.

Instead of looking for specific values (which I don't think TypeList handles too well), just check the number of elements. This line would become resource.TestCheckResourceAttr(name, "settings.0.ciphers.#", "2") however if you swap it to that, you'll see it's empty without any elements too.

[riuvshyn]

mmm now it fails with:

Error: error from makeRequest: HTTP status 400: content "{\"success\":false,\"errors\":[{\"code\":1023,\"message\":\"Advanced Certificate Manager is required to set custom cipher suites\"}],\"messages\":[],\"result\":null}"

seems it requires some extra configuration tobe enabled...

[jacobbednarz]

we'll need to address the failing test on this one before merging

[elovelan]

@riuvshyn, are you still looking into this? would you like me to take it over since I have a need for this?

[jacobbednarz]

@elovelan if you want this functionality, i'd recommend grabbing a new PR and submitting as this one is now stagnent.